fix(auth): add rate limiting for login and signup endpoints#553
fix(auth): add rate limiting for login and signup endpoints#553Ridanshi wants to merge 1 commit into
Conversation
✅ Deploy Preview for github-spy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
More reviews will be available in 46 minutes and 35 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Closes #452
Summary
Adds focused authentication rate limiting for sensitive auth endpoints using
express-rate-limit.Previously, authentication endpoints had no throttling or abuse protection, allowing:
Because every login request reached synchronous
bcryptjspassword verification with no request throttling.This PR introduces scoped rate limiting for authentication-sensitive routes while preserving the existing auth/session behavior and response contracts.
Implementation
Added
express-rate-limitand configured dedicated auth limiters for:POST /api/auth/loginPOST /api/auth/signupLimiter configuration:
Key changes:
The limiter is intentionally scoped only to authentication-sensitive routes.
Files Changed
backend/config/authRateLimit.jsbackend/routes/auth.jsbackend/package.jsonpackage.jsonspec/auth.rate-limit.spec.cjsSecurity Improvements
This reduces exposure to:
Excessive requests now return:
429 Too Many Requestswith standard rate-limit headers enabled.
Tests
Focused regression coverage added for:
Verification
Result:
Full backend suite was also attempted:
Existing unrelated MongoDB-dependent auth/model specs timed out locally, while all newly-added auth rate-limit tests passed successfully.
Notes
This PR intentionally keeps scope limited to authentication abuse protection.
No CAPTCHA, Redis, account-lockout system, auth architecture rewrite, or unrelated middleware refactors were introduced.